Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2261413002: Update test expectation for text annotation. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update text expectations for text annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M pdfium/annots/annotation_text_expected.pdf.0.png View Binary file 0 comments Download
M third_party/tcpdf/example_036_expected.pdf.0.png View 1 Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
jaepark
Updated test expectation from implementing text annotation in https://codereview.chromium.org/2270493002/ .
4 years, 4 months ago (2016-08-22 22:38:30 UTC) #2
Lei Zhang
Does third_party/tcpdf/example_036.pdf also need to be updated?
4 years, 4 months ago (2016-08-22 23:25:18 UTC) #3
jaepark
Updated third_party/tcpdf/example_036.pdf .
4 years, 4 months ago (2016-08-22 23:30:41 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-22 23:59:15 UTC) #5
jaepark
4 years, 4 months ago (2016-08-23 00:18:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
afbac944ba4b41252e4bd16372f27806bc0ed924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698