third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html - Issue 2261393002: Fixed the behaviour of form submit to Firefox: form does not submit once it has been removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html

Issue 2261393002: Fixed the behaviour of form submit to Firefox: form does not submit once it has been removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove form stats Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/form-removed-from-document.html ('k') | third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html » ('j') | third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html b/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html

index ec32a8947c3e644eb80c6a169c8822996ce7d433..cd34c8259919815bbc5471f22e3d91327a4003b3 100644

--- a/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html

+++ b/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html

@@ -2,6 +2,7 @@

+<body></body>

iclelland 2016/08/23 17:46:22 Is this required? I think that the body element wi

lunalu1 2016/08/24 15:24:42 Yes. Otherwise I will get the error "Cannot read p

// Set cookies on ORIGINAL_HOST, then move ourselves to TEST_ROOT so

// we can verify cross-origin behavior.

@@ -29,6 +30,7 @@ if (window.location.hostname == "127.0.0.1") {

f.method = "POST";

f.target = "_blank"

window.onload = t.step_func(f.submit.bind(f));

+ document.body.appendChild(f);

}, "'" + ORIGINAL_HOST + "' is not same-site with '" + TEST_HOST + "', so samesite cookies are not sent via POST.");

}

</script>