third_party/WebKit/Source/core/html/HTMLFormElement.cpp - Issue 2261393002: Fixed the behaviour of form submit to Firefox: form does not submit once it has been removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 2261393002: Fixed the behaviour of form submit to Firefox: form does not submit once it has been removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html ('K') | « third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

index 53b47e973450e2b06b2e9d55df92b5d233e12752..491608592bab77800dda6f306d3f01daa1befdc2 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

@@ -350,9 +350,12 @@ void HTMLFormElement::submit(Event* event, bool activateSubmitButton)

LocalFrame* frame = document().frame();

if (!view || !frame || !frame->page())

return;

+ // Do not submit if the form is not attached to the document.

+ // This matches the behaviour in Firefox.

// See crbug.com/586749.

if (!isConnected())

- UseCounter::count(document(), UseCounter::FormSubmissionNotInDocumentTree);

+ return;

if (m_isSubmitting)

return;