Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2261343002: [WebApk] Installation adds a homescreen shortcut. (Closed)

Created:
4 years, 4 months ago by Xi Han
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebApk] Installation adds a homescreen shortcut. Since installation is going through package installer directly and not play, a shortcut isn't created. Add logic to listen for package installation and manually create a shortcut (there is no callback/event that can be listened to). Note if chrome is evicted, a shortcut won't be created. As this is a temporary solution, it should be fine for now. BUG=636107 Committed: https://crrev.com/723c87a310a6ed30e88292f046b2c19a1d33660f Cr-Commit-Position: refs/heads/master@{#413534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 6 chunks +28 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xi Han
This is a copy of Yaron's CL(https://codereview.chromium.org/2247183008/), and I just rebase and addressed the original ...
4 years, 4 months ago (2016-08-22 19:47:15 UTC) #2
gone
lgtm
4 years, 4 months ago (2016-08-22 19:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261343002/1
4 years, 4 months ago (2016-08-22 19:51:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 21:13:03 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:20:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/723c87a310a6ed30e88292f046b2c19a1d33660f
Cr-Commit-Position: refs/heads/master@{#413534}

Powered by Google App Engine
This is Rietveld 408576698