Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2261323002: Fix an issue that android doesn't know how to open the download after completion (Closed)

Created:
4 years, 4 months ago by qinmin
Modified:
4 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that android doesn't know how to open the download after completion When downloading a file, the Mime type could be generic. Chrome used to callremapGenericMimeType for downloads going through Android DownloadManager. It should do the same for downloads handled by Chrome's network stack. BUG=597914 Committed: https://crrev.com/2f54b5c49b1fe73dd179ac34e81a3d2575ef8cb7 Cr-Commit-Position: refs/heads/master@{#413550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 4 months ago (2016-08-22 19:34:22 UTC) #2
Ted C
lgtm
4 years, 4 months ago (2016-08-22 20:10:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261323002/1
4 years, 4 months ago (2016-08-22 20:29:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 22:11:09 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 22:12:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f54b5c49b1fe73dd179ac34e81a3d2575ef8cb7
Cr-Commit-Position: refs/heads/master@{#413550}

Powered by Google App Engine
This is Rietveld 408576698