Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2261303002: mash: Update Mojo ChromiumOS fyi bot config. (Closed)

Created:
4 years, 4 months ago by msw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org Committed: https://crrev.com/10fa24d67b3d7cca19c634a94fe027c5d8692169 Cr-Commit-Position: refs/heads/master@{#413876}

Patch Set 1 #

Patch Set 2 : Use debug (dchecks and shared) instead of shared release plus dchecks. #

Patch Set 3 : Add TODO to restore release+dcheck. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/mb/mb_config.pyl View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
msw
Hey Dirk, please take a look; thanks! Am I missing any training scripts or similar?
4 years, 4 months ago (2016-08-22 19:09:38 UTC) #1
Dirk Pranke
Why do you want this to be shared release? That's an unusual configuration.
4 years, 4 months ago (2016-08-22 19:22:15 UTC) #2
msw
On 2016/08/22 19:22:15, Dirk Pranke wrote: > Why do you want this to be shared ...
4 years, 4 months ago (2016-08-22 19:25:35 UTC) #4
Dirk Pranke
On 2016/08/22 19:25:35, msw wrote: > On 2016/08/22 19:22:15, Dirk Pranke wrote: > > Why ...
4 years, 4 months ago (2016-08-22 19:40:54 UTC) #5
msw
I made it debug (dchecks and shared) instead of shared release plus dchecks. Sadrul, please ...
4 years, 4 months ago (2016-08-22 20:40:53 UTC) #6
sadrul
On 2016/08/22 20:40:53, msw wrote: > I made it debug (dchecks and shared) instead of ...
4 years, 4 months ago (2016-08-23 01:04:28 UTC) #7
msw
I added a TODO to restore release+dcheck; citing crbug.com/594674 If it's unbearably slow, we can ...
4 years, 4 months ago (2016-08-23 18:17:11 UTC) #8
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-23 19:27:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261303002/40001
4 years, 4 months ago (2016-08-23 19:49:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/267008)
4 years, 4 months ago (2016-08-23 21:14:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261303002/40001
4 years, 4 months ago (2016-08-23 21:39:35 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-23 22:50:33 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 22:53:04 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10fa24d67b3d7cca19c634a94fe027c5d8692169
Cr-Commit-Position: refs/heads/master@{#413876}

Powered by Google App Engine
This is Rietveld 408576698