|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by msw Modified:
4 years, 4 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmash: Update Mojo ChromiumOS fyi bot config.
Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck.
BUG=639882
TEST=Config matches that requested on the bug.
R=dpranke@chromium.org
Committed: https://crrev.com/10fa24d67b3d7cca19c634a94fe027c5d8692169
Cr-Commit-Position: refs/heads/master@{#413876}
Patch Set 1 #Patch Set 2 : Use debug (dchecks and shared) instead of shared release plus dchecks. #Patch Set 3 : Add TODO to restore release+dcheck. #Messages
Total messages: 19 (6 generated)
Hey Dirk, please take a look; thanks! Am I missing any training scripts or similar?
Why do you want this to be shared release? That's an unusual configuration.
Description was changed from ========== mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org ========== to ========== mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org ==========
On 2016/08/22 19:22:15, Dirk Pranke wrote: > Why do you want this to be shared release? That's an unusual configuration. Sadrul said "there are issues with tcmalloc in non-component builds" on the bug, and cited a blocking bug for using the static build with Ozone ( http://crbug.com/594674 - Ozone X11 mash_shell static builds crash in tcmalloc). Perhaps it would make more sense to use a shared debug config until that's fixed?
On 2016/08/22 19:25:35, msw wrote: > On 2016/08/22 19:22:15, Dirk Pranke wrote: > > Why do you want this to be shared release? That's an unusual configuration. > > Sadrul said "there are issues with tcmalloc in non-component builds" on the bug, > and cited a blocking bug for using the static build with Ozone ( > http://crbug.com/594674 - Ozone X11 mash_shell static builds crash in tcmalloc). > Perhaps it would make more sense to use a shared debug config until that's > fixed? I'd either make it a debug config or at least add a comment/TODO with the link to the bug, if you'd really rather it be static release.
I made it debug (dchecks and shared) instead of shared release plus dchecks. Sadrul, please lmk if that should work for us.
On 2016/08/22 20:40:53, msw wrote: > I made it debug (dchecks and shared) instead of shared release plus dchecks. > Sadrul, please lmk if that should work for us. 'debug' config isn't necessary, and I am not sure it would be more useful than release + dcheck. But it shouldn't be a problem either (other than being slower, I guess?). What I am hoping to do with this bot: turn on more browser-tests for mash_browser_tests in this bot first, and graduate them to the main waterfall when they are reliably non-flaky. (same for other tests, e.g. content_browsertests + mus-gpu). Ideally, we would just use the default config (i.e. [static + release + dcheck]), but that combination has issues with tcmalloc. so until that is sorted out, I was thinking we could (temporarily) switch to [component + release + dcheck]. But as mentioned earlier, [component + debug] would also be OK.
I added a TODO to restore release+dcheck; citing crbug.com/594674 If it's unbearably slow, we can try shared release plus dchecks. Dirk, please take a look; thanks!
lgtm
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org ========== to ========== mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org ========== to ========== mash: Update Mojo ChromiumOS fyi bot config. Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck. BUG=639882 TEST=Config matches that requested on the bug. R=dpranke@chromium.org Committed: https://crrev.com/10fa24d67b3d7cca19c634a94fe027c5d8692169 Cr-Commit-Position: refs/heads/master@{#413876} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/10fa24d67b3d7cca19c634a94fe027c5d8692169 Cr-Commit-Position: refs/heads/master@{#413876} |
