Issue 22613003: Remove exported headers and add all public headers into dictionary for reference by clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22613003: Remove exported headers and add all public headers into dictionary for reference by clients. (Closed)

Created:
7 years, 4 months ago by djsollen

Modified:
7 years, 4 months ago

Reviewers:
robertphillips, Torne

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove exported headers and add all public headers into dictionary for reference by clients. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10661

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+316 lines, -133 lines)			Patch
	D	gyp/exported_api_headers.gypi	View		1 chunk	+0 lines, -133 lines	0 comments	Download
	A	gyp/public_headers.gypi	View		1 chunk	+316 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

djsollen

Committed patchset #1 manually as r10661 (presubmit successful).

7 years, 4 months ago (2013-08-09 15:45:39 UTC) #4

Torne

On 2013/08/09 15:45:39, djsollen wrote: > Committed patchset #1 manually as r10661 (presubmit successful). I ...

7 years, 4 months ago (2013-08-09 15:48:20 UTC) #5

djsollen

7 years, 4 months ago (2013-08-09 15:56:18 UTC) #6

Message was sent while issue was closed.

On 2013/08/09 15:48:20, Torne wrote:
> On 2013/08/09 15:45:39, djsollen wrote:
> > Committed patchset #1 manually as r10661 (presubmit successful).
> 
> I don't think this will work, they need to be relative to the system skia's
> include paths (i.e. they need to be core/SkWhatever.h, not include/core) - the
> paths included here are what ends up in the shim headers as #include <foo>

Oops.  I'll patch that up now.

Expand Messages | Collapse Messages