Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2261293002: add kernel to DEPS (Closed)

Created:
4 years, 4 months ago by Harry Terkelsen
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add kernel to DEPS This is in preparation for dart2js to use kernel IR as an input to the backend. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/272bf3d7983502510c057240289ae6202b00106a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M DEPS View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Harry Terkelsen
4 years, 4 months ago (2016-08-22 18:56:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-22 19:24:58 UTC) #3
Siggi Cherem (dart-lang)
oh wait (!lgtm) https://codereview.chromium.org/2261293002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2261293002/diff/1/DEPS#newcode233 DEPS:233: (Var("github_mirror") % "kernel") + Var("kernel_rev"), actually ...
4 years, 4 months ago (2016-08-22 19:26:59 UTC) #4
Siggi Cherem (dart-lang)
lgtm - it's there :)
4 years, 4 months ago (2016-08-22 19:27:47 UTC) #5
Harry Terkelsen
4 years, 4 months ago (2016-08-22 19:41:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
272bf3d7983502510c057240289ae6202b00106a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698