content/public/common/platform_notification_data.h - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/platform_notification_data.h

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/common/notification_resources.h ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/platform_notification_data.h

diff --git a/content/public/common/platform_notification_data.h b/content/public/common/platform_notification_data.h

index 97f723493f75a4ee8d3bbc26650a0a50b29155c0..a2108d0b4b9084b67097d6a707cfa7775fe47b69 100644

--- a/content/public/common/platform_notification_data.h

+++ b/content/public/common/platform_notification_data.h

@@ -83,6 +83,10 @@ struct CONTENT_EXPORT PlatformNotificationData {

// tag will replace the first displayed notification.

std::string tag;

+ // URL of the image contents of the notification. May be empty if no url was

+ // specified.

+ GURL image;

// URL of the icon which is to be displayed with the notification.

GURL icon;