content/common/platform_notification_messages.h - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/platform_notification_messages.h

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check IPC drawsNothing rather than isNull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/platform_notification_messages.h

diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h

index 7f27b8b4168279463cb5ce5f714016de3a523def..525b2b34e324bfb00fe7dfe311d11057920b14e9 100644

--- a/content/common/platform_notification_messages.h

+++ b/content/common/platform_notification_messages.h

@@ -49,6 +49,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationData)

IPC_STRUCT_TRAITS_MEMBER(lang)

IPC_STRUCT_TRAITS_MEMBER(body)

IPC_STRUCT_TRAITS_MEMBER(tag)

+ IPC_STRUCT_TRAITS_MEMBER(image)

IPC_STRUCT_TRAITS_MEMBER(icon)

IPC_STRUCT_TRAITS_MEMBER(badge)

IPC_STRUCT_TRAITS_MEMBER(vibration_pattern)

@@ -61,6 +62,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationData)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::NotificationResources)

+ IPC_STRUCT_TRAITS_MEMBER(image)

IPC_STRUCT_TRAITS_MEMBER(notification_icon)

IPC_STRUCT_TRAITS_MEMBER(badge)

IPC_STRUCT_TRAITS_MEMBER(action_icons)

« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | content/public/common/notification_resources.h » ('j') | no next file with comments »