third_party/WebKit/public/platform/modules/notifications/notification.mojom - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/notifications/notification.mojom

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h ('K') | « third_party/WebKit/public/platform/modules/notifications/WebNotificationResources.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/notifications/notification.mojom

diff --git a/third_party/WebKit/public/platform/modules/notifications/notification.mojom b/third_party/WebKit/public/platform/modules/notifications/notification.mojom

index b969e47eb010b76fa97c8e03afff9b838f430a53..11e61ed5d418e927ab370f21ffb301df6c978f56 100644

--- a/third_party/WebKit/public/platform/modules/notifications/notification.mojom

+++ b/third_party/WebKit/public/platform/modules/notifications/notification.mojom

@@ -58,6 +58,9 @@ struct Notification {

// tag will replace the first displayed notification.

string tag;

+ // URL of the image which is to be displayed with the notification.

+ string image;

Peter Beverloo 2016/08/22 20:11:07 nit: we need to remove this file, no need to add t

johnme 2016/08/23 14:59:49 Done, ditto for content/browser/notifications/type

// URL of the icon which is to be displayed with the notification.

string icon;