Add Notification images (Blink + desktop implementation)

third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebNotificationConstants_h
 #define WebNotificationConstants_h
 
 namespace blink {
 
 // TODO(johnme): The maximum number of actions is platform-specific and should
 // be indicated by the embedder.
 
 // Maximum number of actions on a Platform Notification.
 static const size_t kWebNotificationMaxActions = 2;
 
 // TODO(mvanouwerkerk): Update the notification resource loader to get the
 // appropriate image sizes from the embedder.
 
+// The maximum reasonable image size, scaled from dip units to pixels using the
+// largest supported scaling factor. TODO(johnme): Check sizes are correct.

[Peter Beverloo, 2016/08/22 20:11:07]

Please do this prior to landing the CL.

[johnme, 2016/08/23 14:59:49]

Ack, though gonna be tricky since it's platform-dependent.

[Peter Beverloo, 2016/08/24 15:21:11]

Right now it'd come down to max([android dips] * 4, [desktop dips] * 2), right?
We have to refine these numbers when new (native) platforms are added, and the
browser process should be authoritative over their intended size.

+static const int kWebNotificationMaxImageWidthPx = 1800; // 450 dip * 4
+static const int kWebNotificationMaxImageHeightPx = 900; // 225 dip * 4

[Peter Beverloo, 2016/08/22 20:11:07]

nit: consider s/const/constexpr/ in this file.

[johnme, 2016/08/23 14:59:49]

Done.

+
 // The maximum reasonable notification icon size, scaled from dip units to
 // pixels using the largest supported scaling factor.
 static const int kWebNotificationMaxIconSizePx = 320; // 80 dip * 4
 
 // The maximum reasonable badge size, scaled from dip units to pixels using the
 // largest supported scaling factor.
 static const int kWebNotificationMaxBadgeSizePx = 96; // 24 dip * 4
 
 // The maximum reasonable action icon size, scaled from dip units to
 // pixels using the largest supported scaling factor.
 static const int kWebNotificationMaxActionIconSizePx = 128; // 32 dip * 4
 
 } // namespace blink
 
 #endif // WebNotificationConstants_h