Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2261273002: Integrate UI with authentication flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Misc fix. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/blimp_client_context_impl.h
diff --git a/blimp/client/core/blimp_client_context_impl.h b/blimp/client/core/blimp_client_context_impl.h
index 0748e23d3d9f43e276c35cf1dbefa58e5781586b..9671b33772e3c9326a2c962143aee2d57a019246 100644
--- a/blimp/client/core/blimp_client_context_impl.h
+++ b/blimp/client/core/blimp_client_context_impl.h
@@ -12,6 +12,7 @@
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread.h"
+#include "blimp/client/core/blimp_client_context_internal.h"
David Trainor- moved to gerrit 2016/08/29 05:12:24 Is this used here?
xingliu 2016/08/30 04:47:42 I first expose the identity source in the base cla
#include "blimp/client/core/session/client_network_components.h"
#include "blimp/client/core/session/identity_source.h"
#include "blimp/client/core/session/network_event_observer.h"
@@ -57,6 +58,13 @@ class BlimpClientContextImpl : public BlimpClientContext,
// the AssignmentSource.
virtual GURL GetAssignerURL();
+ // Create IdentitySource which provides user sign in states and OAuth2 token
+ // service.
+ void CreateIdentitySource();
+
+ // Provide OAuth2 token and propagate account sign in states change.
+ std::unique_ptr<IdentitySource> identity_source_;
+
private:
// Connect to assignment source with OAuth2 token to get an assignment.
virtual void ConnectToAssignmentSource(const std::string& client_auth_token);
@@ -91,9 +99,6 @@ class BlimpClientContextImpl : public BlimpClientContext,
std::unique_ptr<ThreadPipeManager> thread_pipe_manager_;
- // Provide OAuth2 token and propagate account sign in states change.
- std::unique_ptr<IdentitySource> identity_source_;
-
base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl);

Powered by Google App Engine
This is Rietveld 408576698