Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: apps/BUILD.gn

Issue 2261253003: Add chrome/browser/extensions to "GN check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dumb typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | ash/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/BUILD.gn
diff --git a/apps/BUILD.gn b/apps/BUILD.gn
index a024fc15d2a21e8bf8b56a2775f8489b9f930b0e..ede4e7e22361262afaae97c3c55d017ab82a4cd0 100644
--- a/apps/BUILD.gn
+++ b/apps/BUILD.gn
@@ -8,55 +8,49 @@ import("//build/config/ui.gni")
assert(!is_android && !is_ios)
static_library("apps") {
- sources = [
- "app_lifetime_monitor.cc",
- "app_lifetime_monitor.h",
- "app_lifetime_monitor_factory.cc",
- "app_lifetime_monitor_factory.h",
- "app_load_service.cc",
- "app_load_service.h",
- "app_load_service_factory.cc",
- "app_load_service_factory.h",
- "app_restore_service.cc",
- "app_restore_service.h",
- "app_restore_service_factory.cc",
- "app_restore_service_factory.h",
- "browser_context_keyed_service_factories.cc",
- "browser_context_keyed_service_factories.h",
- "custom_launcher_page_contents.cc",
- "custom_launcher_page_contents.h",
- "launcher.cc",
- "launcher.h",
- "metrics_names.h",
- "saved_files_service.cc",
- "saved_files_service.h",
- "saved_files_service_factory.cc",
- "saved_files_service_factory.h",
- "switches.cc",
- "switches.h",
- ]
+ sources = []
- configs += [ "//build/config/compiler:wexit_time_destructors" ]
+ if (enable_extensions) {
+ sources += [
+ "app_lifetime_monitor.cc",
+ "app_lifetime_monitor.h",
+ "app_lifetime_monitor_factory.cc",
+ "app_lifetime_monitor_factory.h",
+ "app_load_service.cc",
+ "app_load_service.h",
+ "app_load_service_factory.cc",
+ "app_load_service_factory.h",
+ "app_restore_service.cc",
+ "app_restore_service.h",
+ "app_restore_service_factory.cc",
+ "app_restore_service_factory.h",
+ "browser_context_keyed_service_factories.cc",
+ "browser_context_keyed_service_factories.h",
+ "custom_launcher_page_contents.cc",
+ "custom_launcher_page_contents.h",
+ "launcher.cc",
+ "launcher.h",
+ "metrics_names.h",
+ "saved_files_service.cc",
+ "saved_files_service.h",
+ "saved_files_service_factory.cc",
+ "saved_files_service_factory.h",
+ "switches.cc",
+ "switches.h",
+ ]
- deps = [
- "//chrome/app/theme:theme_resources",
- "//chrome/browser/extensions",
- "//chrome/common/extensions/api:api",
- "//components/web_modal",
- "//skia",
- ]
+ configs += [ "//build/config/compiler:wexit_time_destructors" ]
- if (is_chromeos) {
- #deps += [ "browser_chromeos" ] TODO(GYP)
- }
-
- if (!enable_extensions) {
- # When extensions are disabled, only the sizer file below is included.
- deps -= [
+ deps = [
+ "//chrome/app/theme:theme_resources",
"//chrome/browser/extensions",
- "//chrome/common/extensions/api:api",
+ "//chrome/common/extensions/api",
+ "//components/web_modal",
+ "//skia",
]
- sources = []
+
+ # TODO: This top level directory should not have an include cycle.
+ allow_circular_includes_from = [ "//chrome/browser/extensions" ]
}
if (toolkit_views) {
« no previous file with comments | « .gn ('k') | ash/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698