Add chrome/browser/extensions to "GN check"

Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in https://codereview.chromium.org/773303005/, but this doesn't match the definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the mismatch).

Committed: https://crrev.com/afa8f54cfb452e954c8487739de295163112561a
Cr-Commit-Position: refs/heads/master@{#413985}

[brettw, 2016-08-22 22:43:27]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-08-22 22:43:33]

brettw@chromium.org changed reviewers:
+ asargent@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:49:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-08-22 23:21:22]

.

[brettw, 2016-08-22 23:21:23]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:22:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asargent_no_longer_on_chrome, 2016-08-22 23:26:17]

lgtm

[commit-bot: I haz the power, 2016-08-22 23:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:26:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-08-22 23:35:47]

.

[brettw, 2016-08-22 23:35:47]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-22 23:35:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2261253003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-08-22 23:36:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:42:20]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-08-23 17:22:47]

Description was changed from

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose m ore deps as
public, refactors //apps's BUILD file.
==========

to

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose m ore deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.
==========

[brettw, 2016-08-23 17:22:58]

chromeos

[brettw, 2016-08-23 17:22:59]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-08-23 17:23:23]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-08-23 17:23:27]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-23 17:23:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2261253003/#ps80001
(title: "chromeos")

[commit-bot: I haz the power, 2016-08-23 17:24:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:32:24]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[brettw, 2016-08-23 19:52:12]

cast

[brettw, 2016-08-23 19:52:12]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-23 19:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2261253003/#ps100001
(title: "cast")

[commit-bot: I haz the power, 2016-08-23 19:53:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 20:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 20:03:02]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[brettw, 2016-08-23 21:06:38]

event_router

[brettw, 2016-08-23 21:06:39]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-23 21:06:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2261253003/#ps120001
(title: "event_router")

[commit-bot: I haz the power, 2016-08-23 21:07:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-23 21:07:57]

Description was changed from

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose m ore deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.
==========

to

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose m ore deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).
==========

[brettw, 2016-08-23 21:09:40]

really

[brettw, 2016-08-23 21:09:41]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-23 21:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2261253003/#ps140001
(title: "really")

[commit-bot: I haz the power, 2016-08-23 21:10:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 21:20:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-08-23 21:28:27]

dumb typo

[brettw, 2016-08-23 21:28:28]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-23 21:28:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2261253003/#ps160001
(title: "dumb typo")

[commit-bot: I haz the power, 2016-08-23 21:29:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-23 21:59:01]

Description was changed from

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose m ore deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).
==========

to

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).
==========

[commit-bot: I haz the power, 2016-08-24 00:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 00:23:54]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2016-08-24 04:12:16]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-24 04:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 05:16:39]

Description was changed from

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).
==========

to

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).
==========

[commit-bot: I haz the power, 2016-08-24 05:16:40]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-24 05:19:25]

Description was changed from

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).
==========

to

==========
Add chrome/browser/extensions to "GN check"

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style
consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from
TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in
https://codereview.chromium.org/773303005/, but this doesn't match the
definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the
mismatch).

Committed: https://crrev.com/afa8f54cfb452e954c8487739de295163112561a
Cr-Commit-Position: refs/heads/master@{#413985}
==========

[commit-bot: I haz the power, 2016-08-24 05:19:27]

Patchset 9 (id:??) landed as
https://crrev.com/afa8f54cfb452e954c8487739de295163112561a
Cr-Commit-Position: refs/heads/master@{#413985}