Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2261123004: Mark temp paths in SkBaseDevice::drawArc and ::drawDRRect as volatile (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mark temp paths in SkBaseDevice::drawArc and ::drawDRRect as volatile GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261123004 Committed: https://skia.googlesource.com/skia/+/6bf233176f49ce1b810f0c48b23641ec148da7bd

Patch Set 1 #

Patch Set 2 : move line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkDevice.cpp View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
bsalomon
4 years, 4 months ago (2016-08-22 17:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261123004/20001
4 years, 4 months ago (2016-08-22 17:21:03 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 4 months ago (2016-08-22 17:21:08 UTC) #6
reed1
Seems like volatile can/should be added everywhere in SkDevice that we make a temp path, ...
4 years, 4 months ago (2016-08-22 18:37:14 UTC) #8
robertphillips
lgtm, although Mike's point that we should do this where ever we can is a ...
4 years, 4 months ago (2016-08-22 18:45:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6bf233176f49ce1b810f0c48b23641ec148da7bd
4 years, 4 months ago (2016-08-22 18:46:38 UTC) #11
bsalomon
On 2016/08/22 18:45:37, robertphillips wrote: > lgtm, although Mike's point that we should do this ...
4 years, 4 months ago (2016-08-22 18:47:45 UTC) #12
reed1
On 2016/08/22 18:47:45, bsalomon wrote: > On 2016/08/22 18:45:37, robertphillips wrote: > > lgtm, although ...
4 years, 4 months ago (2016-08-22 18:53:48 UTC) #13
reed1
4 years, 4 months ago (2016-08-22 19:00:13 UTC) #14
Message was sent while issue was closed.
On 2016/08/22 18:53:48, reed1 wrote:
> On 2016/08/22 18:47:45, bsalomon wrote:
> > On 2016/08/22 18:45:37, robertphillips wrote:
> > > lgtm, although Mike's point that we should do this where ever we can is a
> good
> > > one.
> > 
> > Yes, but this completes the set in SkDevice.cpp. The others already do use
> > volatile.
> 
> SkBaseDevice::drawDRRect ?

Doh -- didn't see your #2, thanks.

Powered by Google App Engine
This is Rietveld 408576698