Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2261123002:
[compiler] Fix uncommon CompileOptimized fallback. (Closed)
|
Created:
4 years, 4 months ago by Michael Starzinger Modified:
4 years, 4 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[compiler] Fix uncommon CompileOptimized fallback.
This fixes the uncommon fallback when Compiler::CompileOptimized fails
creating optimized code and also the underlying SharedFunctionInfo is
not compiled. We make sure not to uselessly regenerate the bytecode.
R=rmcilroy@chromium.org
BUG=chromium:639753
Committed: https://crrev.com/a311bfa693db5590a5f221e5ea4dc7dbd0554463
Cr-Commit-Position: refs/heads/master@{#38776}
Patch Set 1 #Patch Set 2 : Fix release mode. #Patch Set 3 : No simplify. :( #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
Description was changed from ========== [compiler] Simplify and fix CompileOptimized fallback. This fixes the uncommon fallback when Compiler::CompileOptimized fails creating optimized code and also the underlying SharedFunctionInfo is not compiled. We make sure not to uselessly regenerate the bytecode. R=rmcilroy@chromium.org BUG=chromium:639753 ========== to ========== [compiler] Fix uncommon CompileOptimized fallback. This fixes the uncommon fallback when Compiler::CompileOptimized fails creating optimized code and also the underlying SharedFunctionInfo is not compiled. We make sure not to uselessly regenerate the bytecode. R=rmcilroy@chromium.org BUG=chromium:639753 ==========
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [compiler] Fix uncommon CompileOptimized fallback. This fixes the uncommon fallback when Compiler::CompileOptimized fails creating optimized code and also the underlying SharedFunctionInfo is not compiled. We make sure not to uselessly regenerate the bytecode. R=rmcilroy@chromium.org BUG=chromium:639753 ========== to ========== [compiler] Fix uncommon CompileOptimized fallback. This fixes the uncommon fallback when Compiler::CompileOptimized fails creating optimized code and also the underlying SharedFunctionInfo is not compiled. We make sure not to uselessly regenerate the bytecode. R=rmcilroy@chromium.org BUG=chromium:639753 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [compiler] Fix uncommon CompileOptimized fallback. This fixes the uncommon fallback when Compiler::CompileOptimized fails creating optimized code and also the underlying SharedFunctionInfo is not compiled. We make sure not to uselessly regenerate the bytecode. R=rmcilroy@chromium.org BUG=chromium:639753 ========== to ========== [compiler] Fix uncommon CompileOptimized fallback. This fixes the uncommon fallback when Compiler::CompileOptimized fails creating optimized code and also the underlying SharedFunctionInfo is not compiled. We make sure not to uselessly regenerate the bytecode. R=rmcilroy@chromium.org BUG=chromium:639753 Committed: https://crrev.com/a311bfa693db5590a5f221e5ea4dc7dbd0554463 Cr-Commit-Position: refs/heads/master@{#38776} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a311bfa693db5590a5f221e5ea4dc7dbd0554463 Cr-Commit-Position: refs/heads/master@{#38776} |
