cc/animation/scroll_offset_animations.cc - Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/scroll_offset_animations.cc

Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/animation/scroll_offset_animations.cc

diff --git a/cc/animation/scroll_offset_animations.cc b/cc/animation/scroll_offset_animations.cc

index 04cf954c6f27ad286dafc83fb3f076a9c81c338c..c70abbc9299cc28f73cd4031a94b39fe3c1c6ca1 100644

--- a/cc/animation/scroll_offset_animations.cc

+++ b/cc/animation/scroll_offset_animations.cc

@@ -33,7 +33,7 @@ void ScrollOffsetAnimations::AddAdjustmentUpdate(ElementId element_id,

ScrollOffsetAnimationUpdate update = GetUpdateForElementId(element_id);

update.adjustment_ += adjustment;

element_to_update_map_[element_id] = update;

- animation_host_->SetNeedsCommit();

+ animation_host_->SetNeedsPushProperties();

}

void ScrollOffsetAnimations::AddTakeoverUpdate(ElementId element_id) {

@@ -41,7 +41,7 @@ void ScrollOffsetAnimations::AddTakeoverUpdate(ElementId element_id) {

ScrollOffsetAnimationUpdate update = GetUpdateForElementId(element_id);

update.takeover_ = true;

element_to_update_map_[element_id] = update;

- animation_host_->SetNeedsCommit();

+ animation_host_->SetNeedsPushProperties();

}

bool ScrollOffsetAnimations::HasUpdatesForTesting() const {

« no previous file with comments | « cc/animation/element_animations_unittest.cc ('k') | cc/test/animation_test_common.h » ('j') | cc/test/animation_test_common.cc » ('J')