Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: cc/test/animation_timelines_test_common.cc

Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not change SetNeedsCommit invalidation, leave it as-is. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/animation_timelines_test_common.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/animation_timelines_test_common.cc
diff --git a/cc/test/animation_timelines_test_common.cc b/cc/test/animation_timelines_test_common.cc
index 5f640b8091f5e53e2cd50cd894511cb12428a887..1567e490408c7097fe2e2fe93ab32e7f20abf85b 100644
--- a/cc/test/animation_timelines_test_common.cc
+++ b/cc/test/animation_timelines_test_common.cc
@@ -518,4 +518,33 @@ int AnimationTimelinesTest::NextTestLayerId() {
return next_test_layer_id_;
}
+bool AnimationTimelinesTest::CheckPlayerTimelineNeedsPushProperties(
+ bool needs_push_properties) const {
+ DCHECK(player_);
+ DCHECK(timeline_);
+
+ bool result = true;
+
+ if (player_->needs_push_properties() != needs_push_properties) {
+ ADD_FAILURE() << "player_->needs_push_properties() expected to be "
+ << needs_push_properties;
+ result = false;
+ }
+ if (timeline_->needs_push_properties() != needs_push_properties) {
+ ADD_FAILURE() << "timeline_->needs_push_properties() expected to be "
+ << needs_push_properties;
+ result = false;
+ }
+ if (player_->element_animations() &&
+ player_->element_animations()->needs_push_properties() !=
+ needs_push_properties) {
+ ADD_FAILURE() << "player_->element_animations()->needs_push_properties() "
+ "expected to be "
+ << needs_push_properties;
+ result = false;
+ }
+
+ return result;
+}
+
} // namespace cc
« no previous file with comments | « cc/test/animation_timelines_test_common.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698