Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: cc/animation/scroll_offset_animations.cc

Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not change SetNeedsCommit invalidation, leave it as-is. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/animation/element_animations_unittest.cc ('k') | cc/test/animation_timelines_test_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/scroll_offset_animations.cc
diff --git a/cc/animation/scroll_offset_animations.cc b/cc/animation/scroll_offset_animations.cc
index 04cf954c6f27ad286dafc83fb3f076a9c81c338c..3998c89a8db44388fe152823863d3d82201168fc 100644
--- a/cc/animation/scroll_offset_animations.cc
+++ b/cc/animation/scroll_offset_animations.cc
@@ -34,6 +34,7 @@ void ScrollOffsetAnimations::AddAdjustmentUpdate(ElementId element_id,
update.adjustment_ += adjustment;
element_to_update_map_[element_id] = update;
animation_host_->SetNeedsCommit();
+ animation_host_->SetNeedsPushProperties();
}
void ScrollOffsetAnimations::AddTakeoverUpdate(ElementId element_id) {
@@ -42,6 +43,7 @@ void ScrollOffsetAnimations::AddTakeoverUpdate(ElementId element_id) {
update.takeover_ = true;
element_to_update_map_[element_id] = update;
animation_host_->SetNeedsCommit();
+ animation_host_->SetNeedsPushProperties();
}
bool ScrollOffsetAnimations::HasUpdatesForTesting() const {
« no previous file with comments | « cc/animation/element_animations_unittest.cc ('k') | cc/test/animation_timelines_test_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698