cc/animation/animation_player_unittest.cc - Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/animation_player_unittest.cc

Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/animation/animation_player_unittest.cc

diff --git a/cc/animation/animation_player_unittest.cc b/cc/animation/animation_player_unittest.cc

index 41acac4a01f0cc220802e548ca356a9c3d328d09..8354bbccb6f3a0785e749748b287a429b0befa29 100644

--- a/cc/animation/animation_player_unittest.cc

+++ b/cc/animation/animation_player_unittest.cc

@@ -312,7 +312,8 @@ TEST_F(AnimationPlayerTest, AddRemoveAnimationCausesSetNeedsCommit) {

timeline_->AttachPlayer(player_);

player_->AttachElement(element_id_);

- EXPECT_FALSE(client_.mutators_need_commit());

+ EXPECT_TRUE(client_.mutators_need_commit());

+ client_.set_mutators_need_commit(false);

const int animation_id =

AddOpacityTransitionToPlayer(player_.get(), 1., .7f, .3f, false);

« no previous file with comments | « cc/animation/animation_player.cc ('k') | cc/animation/animation_timeline.h » ('j') | cc/animation/element_animations_unittest.cc » ('J')