Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4533)

Unified Diff: cc/animation/animation_player.h

Issue 2261113002: CC Animation: Introduce some dirty flags to optimize PushProperties on commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/animation/animation_player.h
diff --git a/cc/animation/animation_player.h b/cc/animation/animation_player.h
index 5c4c58e94db4c7fdf3ed8f220b668a02b29b8fe7..0445371ad8b258961d06f2a4b126d14d4d2f2b0a 100644
--- a/cc/animation/animation_player.h
+++ b/cc/animation/animation_player.h
@@ -82,6 +82,7 @@ class CC_EXPORT AnimationPlayer : public base::RefCounted<AnimationPlayer> {
void NotifyAnimationAborted(base::TimeTicks monotonic_time,
TargetProperty::Type target_property,
int group);
+ void NotifyAnimationWaitingForDeletion();
void NotifyAnimationTakeover(base::TimeTicks monotonic_time,
TargetProperty::Type target_property,
double animation_start_time,
@@ -92,13 +93,15 @@ class CC_EXPORT AnimationPlayer : public base::RefCounted<AnimationPlayer> {
return !animations_.empty();
}
+ bool needs_push_properties() const { return needs_push_properties_; }
+
private:
friend class base::RefCounted<AnimationPlayer>;
explicit AnimationPlayer(int id);
~AnimationPlayer();
- void SetNeedsCommit();
+ void SetNeedsPushProperties();
void RegisterPlayer();
void UnregisterPlayer();
@@ -119,6 +122,7 @@ class CC_EXPORT AnimationPlayer : public base::RefCounted<AnimationPlayer> {
int id_;
ElementId element_id_;
+ bool needs_push_properties_;
DISALLOW_COPY_AND_ASSIGN(AnimationPlayer);
};

Powered by Google App Engine
This is Rietveld 408576698