CC Animation: Introduce some dirty flags to optimize PushProperties on commit

cc/test/animation_timelines_test_common.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/animation_timelines_test_common.h"
 
 #include "base/memory/ptr_util.h"
 #include "cc/animation/animation_events.h"
 #include "cc/animation/animation_id_provider.h"
 #include "cc/animation/animation_player.h"
@@ skipping 500 matching lines @@
                    &element_animations->players_list())
                    .GetNext()
              : nullptr;
 }
 
 int AnimationTimelinesTest::NextTestLayerId() {
   next_test_layer_id_++;
   return next_test_layer_id_;
 }
 
+void AnimationTimelinesTest::ExpectPlayerTimelineNeedsPushProperties(

[ajuma, 2016/08/24 15:52:37]

Putting this in a function rather than a macro means that if a test that uses it
fails, the line number that gets output will be one of the lines below rather
than the calling line in the test (so it's harder to track down the failure).

[loyso (OOO), 2016/08/25 00:38:24]

Failures in each particular are very rare - those are exceptional situations. On
the contrary, we read/modify/support the test code on a permanent basis. Code
bloating doesn't help in this case at all.

Do you suggest to replace function with a macro?

[loyso (OOO), 2016/08/25 00:55:50]

I can replace it with CHECK so it crashes and shows the backtrace.

[danakj, 2016/08/25 01:05:59]

You can return false from this function if any expectations fail (and
ADD_FAILURE() what it was). Then EXPECT_TRUE() on calls to this function.

[loyso (OOO), 2016/08/25 03:59:02]

Done.

+    bool needs_push_properties) {
+  DCHECK(player_);
+  DCHECK(timeline_);
+
+  EXPECT_EQ(needs_push_properties, player_->needs_push_properties());
+  EXPECT_EQ(needs_push_properties, timeline_->needs_push_properties());
+  if (player_->element_animations())
+    EXPECT_EQ(needs_push_properties,
+              player_->element_animations()->needs_push_properties());
+}
+
 }  // namespace cc