components/cronet/android/cronet_url_request_adapter.h - Issue 2261103002: Use modified URLRequest::Read() and delegate methods in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_adapter.h

Issue 2261103002: Use modified URLRequest::Read() and delegate methods in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/certificate_transparency/log_proof_fetcher.cc ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_adapter.h

diff --git a/components/cronet/android/cronet_url_request_adapter.h b/components/cronet/android/cronet_url_request_adapter.h

index 66a7620a5124caddc5da3bf583f9f11300deb839..b8c2d102e4e2ff85138d01e5bc5ef0c65c8b001b 100644

--- a/components/cronet/android/cronet_url_request_adapter.h

+++ b/components/cronet/android/cronet_url_request_adapter.h

@@ -117,7 +117,7 @@ class CronetURLRequestAdapter : public net::URLRequest::Delegate {

void OnSSLCertificateError(net::URLRequest* request,

const net::SSLInfo& ssl_info,

bool fatal) override;

- void OnResponseStarted(net::URLRequest* request) override;

+ void OnResponseStarted(net::URLRequest* request, int net_error) override;

void OnReadCompleted(net::URLRequest* request, int bytes_read) override;

net::URLRequest* GetURLRequestForTesting();

@@ -136,9 +136,8 @@ class CronetURLRequestAdapter : public net::URLRequest::Delegate {

int buffer_size);

void DestroyOnNetworkThread(bool send_on_canceled);

- // Checks status of the request_adapter, return false if |is_success()| is

- // true, otherwise report error and cancel request_adapter.

- bool MaybeReportError(net::URLRequest* request) const;

+ // Report error and cancel request_adapter.

+ void ReportError(net::URLRequest* request, int net_error) const;

CronetURLRequestContextAdapter* context_;