Issue 22611009: H-BuildIncrement should make use of available type feedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22611009: H-BuildIncrement should make use of available type feedback (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

H-BuildIncrement should make use of available type feedback R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16353

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
M	src/ast.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
A +	test/mjsunit/compiler/increment-typefeedback.js	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

Fixed casting bug, please take another quick look. (Also rebased, sorry about that.)

7 years, 3 months ago (2013-08-27 10:59:14 UTC) #3

Toon Verwaest

lgtm. Constant folding while adding instructions is a bit scary.

7 years, 3 months ago (2013-08-27 11:05:13 UTC) #4

Jakob Kummerow

7 years, 3 months ago (2013-08-27 11:45:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r16353 (presubmit successful).