Switch over MobileActivator to use Network*Handler

chromeos/network/network_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 99 matching lines @@
   // parsed.
   static bool GetUIDataFromValue(const base::Value& value, NetworkUIData* out);
 
   // Generates a name from properties."Wifi.HexSSID" if present, otherwise
   // validates properties.Name and returns a valid utf8 version.
   static std::string GetNameFromProperties(
       const std::string& service_path,
       const base::DictionaryValue& properties);
 
  private:
+  friend class MobileActivatorTest;

[armansito, 2013/08/14 00:49:51]

I see the convenience of making this a friend but is this absolutely necessary
and would it be hard to implement this test without it? (The same applies for
NetworkChangeNotifierChromeosUpdateTest below, though it's not related to this
CL).

[stevenjb, 2013/08/14 02:28:31]

I personally prefer using 'friend' for tests and keeping the members/accessors
private, assuming that the test actually needs access to them. (As opposed to
writing special ForTest accessors for trivial getters).

[gauravsh, 2013/08/14 21:42:29]

In this particular case, it's needed to manually set the state and
activation_state of a NetworkState.

Since there's a lot of precedent for the "friend class <TestFixture>" in the
chromium code base, I also find this preferable to adding a Set*ForTest to
NetworkState.

   friend class NetworkStateHandler;
   friend class NetworkChangeNotifierChromeosUpdateTest;
 
   // Updates |name_| from WiFi.HexSSID if provided, and validates |name_|.
   // Returns true if |name_| changes.
   bool UpdateName(const base::DictionaryValue& properties);
 
   // TODO(gauravsh): Audit the list of properties that we are caching. We should
   // only be doing this for commonly accessed properties. crbug.com/252553
   // Common Network Service properties
@@ skipping 37 matching lines @@
   // Whether a deprecated CaCertNSS property of this network is set. Required
   // for migration to PEM.
   bool has_ca_cert_nss_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_H_