Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2261053002: Supress deprecation warnings in a deprecated library (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-21 15:01:44 UTC) #2
scheglov
LGTM Do we need a new test to cover this?
4 years, 4 months ago (2016-08-21 18:04:27 UTC) #3
Brian Wilkerson
Done
4 years, 4 months ago (2016-08-21 22:47:12 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-08-21 22:47:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79f190cf6933e37aa2aa92168c80871485806405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698