Files app: Concatenate background scripts.

Files app: Concatenate background scripts.

Concatenate scripts to:
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211 KB),
but I think it worth doing.

BUG=639225, 636289
TEST=run browser_tests

Committed: https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7
Cr-Commit-Position: refs/heads/master@{#413677}

[fukino, 2016-08-22 08:39:44]

Description was changed from

==========
Files app: Concatenate background scripts.

BUG=639225
TEST=run browser_tests
==========

to

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divice JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225
TEST=run browser_tests
==========

[fukino, 2016-08-22 08:40:29]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[fukino, 2016-08-22 08:40:29]

PTAL. Thanks!

[fukino, 2016-08-22 08:45:19]

Description was changed from

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divice JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225
TEST=run browser_tests
==========

to

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225
TEST=run browser_tests
==========

[fukino, 2016-08-22 08:46:08]

Description was changed from

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225
TEST=run browser_tests
==========

to

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225,636289
TEST=run browser_tests
==========

[oka, 2016-08-23 02:06:12]

lgtm

LGTM with nits.

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/background_scripts.js (right):

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/background_scripts.js:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
Nit: Could you set --similarity appropriately (say 70?) to avoid false copy
detection?

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/gallery/man...
File ui/file_manager/gallery/manifest.json (right):

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/gallery/man...
ui/file_manager/gallery/manifest.json:62:
"chrome://resources/js/load_time_data.js",
nit: sort.

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/gallery/man...
ui/file_manager/gallery/manifest.json:66: "chrome://resources/js/analytics.js",
nit: sort.

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/image_loade...
File ui/file_manager/image_loader/background_scripts.js (right):

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/image_loade...
ui/file_manager/image_loader/background_scripts.js:5: <include src="cache.js">
nit: sort.

[fukino, 2016-08-23 05:21:08]

Thanks!

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/audio_playe...
File ui/file_manager/audio_player/js/background_scripts.js (right):

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/audio_playe...
ui/file_manager/audio_player/js/background_scripts.js:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2016/08/23 02:06:12, oka wrote:
> Nit: Could you set --similarity appropriately (say 70?) to avoid false copy
> detection?

Used 70, but still detected.
I'll use 100 next time :)

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/gallery/man...
File ui/file_manager/gallery/manifest.json (right):

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/gallery/man...
ui/file_manager/gallery/manifest.json:62:
"chrome://resources/js/load_time_data.js",
On 2016/08/23 02:06:12, oka wrote:
> nit: sort.

Done.

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/gallery/man...
ui/file_manager/gallery/manifest.json:66: "chrome://resources/js/analytics.js",
On 2016/08/23 02:06:12, oka wrote:
> nit: sort.

Done.

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/image_loade...
File ui/file_manager/image_loader/background_scripts.js (right):

https://codereview.chromium.org/2261043003/diff/1/ui/file_manager/image_loade...
ui/file_manager/image_loader/background_scripts.js:5: <include src="cache.js">
On 2016/08/23 02:06:12, oka wrote:
> nit: sort.

Done.

[fukino, 2016-08-23 05:21:14]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-08-23 05:21:14]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2261043003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-23 05:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 06:09:58]

Description was changed from

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225,636289
TEST=run browser_tests
==========

to

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225,636289
TEST=run browser_tests
==========

[commit-bot: I haz the power, 2016-08-23 06:09:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-23 06:13:05]

Description was changed from

==========
Files app: Concatenate background scripts.

Concatenate scripts to: 
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225,636289
TEST=run browser_tests
==========

to

==========
Files app: Concatenate background scripts.

Concatenate scripts to:
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211
KB),
but I think it worth doing.

BUG=639225,636289
TEST=run browser_tests

Committed: https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7
Cr-Commit-Position: refs/heads/master@{#413677}
==========

[commit-bot: I haz the power, 2016-08-23 06:13:06]

Patchset 2 (id:??) landed as
https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7
Cr-Commit-Position: refs/heads/master@{#413677}

[Dan Beam, 2016-08-24 00:01:29]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-08-24 00:01:30]

note: vulcanize is a much better way to handle this, IMO

[fukino, 2016-08-24 02:20:41]

On 2016/08/24 00:01:30, Dan Beam wrote:
> note: vulcanize is a much better way to handle this, IMO

Thank you for the suggestion!
For now we don't use vulcanize as we are concerned about following points and
grit looks simpler unless we don't use HTML imports heavily.
- We need to run vulcanize every time we modify our code (At least, when we
commit the change or run tests)
- We need to commit the generated script as well as modified scripts to the git
repository.

We're going to re-consider vulcanize when the overhead of HTML imports gets
bigger or we get a simpler build process.