store info in basedevice, change getter to non-virtual const&

store info in basedevice, change getter to non-virtual const&

The fact that bitmapdevice can be resized at all is somewhat of a hack to all picture-recording to reuse its canvas at different sizes (with the same device to save on allocations). If we can find an alternate solution for that, we can make fInfo truly const.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003

Committed: https://skia.googlesource.com/skia/+/589a39eb81d25fa7af95e7366db17ac7a70a7d03

[reed1, 2016-08-20 14:05:08]

Description was changed from

==========
store info in basedevice, change getter to non-virtual const&

BUG=skia:
==========

to

==========
store info in basedevice, change getter to non-virtual const&

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003
==========

[reed1, 2016-08-20 14:05:59]

reed@google.com changed reviewers:
+ bsalomon@google.com, fmalita@chromium.org

[reed1, 2016-08-20 14:06:00]

speeds up simplerect, where imageInfo() is 2-3%

[reed1, 2016-08-20 14:06:05]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-08-20 14:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-08-20 14:57:29]

lgtm

https://codereview.chromium.org/2261003003/diff/1/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/2261003003/diff/1/include/core/SkDevice.h#new...
include/core/SkDevice.h:376: *const_cast<SkImageInfo*>(&fInfo) = fInfo.makeWH(w,
h);
why not just make it non-const? Also, there's a whole clique of friends up at
line 343.

[commit-bot: I haz the power, 2016-08-20 14:59:22]

Description was changed from

==========
store info in basedevice, change getter to non-virtual const&

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003
==========

to

==========
store info in basedevice, change getter to non-virtual const&

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003

Committed:
https://skia.googlesource.com/skia/+/589a39eb81d25fa7af95e7366db17ac7a70a7d03
==========

[commit-bot: I haz the power, 2016-08-20 14:59:22]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/589a39eb81d25fa7af95e7366db17ac7a70a7d03

[reed1, 2016-08-20 16:21:22]

Description was changed from

==========
store info in basedevice, change getter to non-virtual const&

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003

Committed:
https://skia.googlesource.com/skia/+/589a39eb81d25fa7af95e7366db17ac7a70a7d03
==========

to

==========
store info in basedevice, change getter to non-virtual const&

The fact that bitmapdevice can be resized at all is somewhat of a hack to all
picture-recording to reuse its canvas at different sizes (with the same device
to save on allocations). If we can find an alternate solution for that, we can
make fInfo truly const.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003

Committed:
https://skia.googlesource.com/skia/+/589a39eb81d25fa7af95e7366db17ac7a70a7d03
==========

[reed1, 2016-08-20 16:22:22]

On 2016/08/20 14:57:29, bsalomon wrote:
> lgtm
> 
> https://codereview.chromium.org/2261003003/diff/1/include/core/SkDevice.h
> File include/core/SkDevice.h (right):
> 
>
https://codereview.chromium.org/2261003003/diff/1/include/core/SkDevice.h#new...
> include/core/SkDevice.h:376: *const_cast<SkImageInfo*>(&fInfo) =
fInfo.makeWH(w,
> h);
> why not just make it non-const? Also, there's a whole clique of friends up at
> line 343.

I've updated the CL comment. BitmapDevice is only friended for that one call
(guilt by colocation). Hopefully we can find a way to not have resizing at all.