Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 22610006: [SPDY] Count closed-stream DATA frames for session flow control (Closed)

Created:
7 years, 4 months ago by akalin
Modified:
7 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

[SPDY] Count closed-stream DATA frames for session flow control This ensures that both sides' flow control states stay in sync even if one side resets a stream. BUG=269873 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217107

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M net/spdy/spdy_session.cc View 1 2 chunks +20 lines, -14 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+rch for review
7 years, 4 months ago (2013-08-08 23:04:28 UTC) #1
akalin
On 2013/08/08 23:04:28, akalin wrote: > +rch for review ping!
7 years, 4 months ago (2013-08-12 21:27:19 UTC) #2
Ryan Hamilton
sorry for the delay, this is probably lgtm, but I'm confused about the disconnect between ...
7 years, 4 months ago (2013-08-12 21:32:06 UTC) #3
akalin
PTAL! https://codereview.chromium.org/22610006/diff/1/net/spdy/spdy_session_unittest.cc File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/22610006/diff/1/net/spdy/spdy_session_unittest.cc#newcode3181 net/spdy/spdy_session_unittest.cc:3181: // receive window size to decrease, but it ...
7 years, 4 months ago (2013-08-12 21:41:19 UTC) #4
Ryan Hamilton
LGTM!
7 years, 4 months ago (2013-08-12 21:52:11 UTC) #5
akalin
7 years, 4 months ago (2013-08-12 22:55:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r217107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698