Issue 2260993002: Don't add empty typeinfo lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2260993002: Don't add empty typeinfo lists (Closed)

Created:
4 years, 4 months ago by sra1

Modified:
4 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't add empty typeinfo lists A 'classNeedsRti' sometimes when it has no type arguments, e.g. CodeUnits needs the substitutions to act as Iterable<int>. It also happens for all classes when .runtimeType is used :-( BUG= Committed: https://github.com/dart-lang/sdk/commit/4eecf5dfa0eea1fcf6b13fdf5ca8e4c73cfe3372

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/ssa/builder.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

sra1

Committed patchset #1 (id:1) manually as 4eecf5dfa0eea1fcf6b13fdf5ca8e4c73cfe3372 (presubmit successful).

4 years, 4 months ago (2016-08-20 01:14:27 UTC) #4

Message was sent while issue was closed.

lgtm