Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2260973003: Don't handle the tab press event in the window cycle event filter. (Closed)

Created:
4 years, 4 months ago by flackr
Modified:
4 years, 4 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Don't handle the tab press event in the window cycle event filter. Because fullscreen windows are allowed to handle alt+tab, we have to be careful not to handle the tab press event in the window cycle event filter as it will be treated as a fullscreen window preventing alt-tabbing. BUG=622396 TEST=WindowCycleControllerTest.TabPastFullscreenWindow,WindowCycleControllerTest.TabKeyNotLeaked TBR=varkha@chromium.org Review-Url: https://codereview.chromium.org/2252673002 Cr-Commit-Position: refs/heads/master@{#412616} (cherry picked from commit 66b4142cfaf0acc038f220b6288089f8a60b923d) Committed: https://chromium.googlesource.com/chromium/src/+/cc813d84d461f08d853e621a1fda109bfe78060e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M ash/wm/window_cycle_controller.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
flackr
4 years, 4 months ago (2016-08-20 03:23:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc813d84d461f08d853e621a1fda109bfe78060e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698