Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2260963003: [Offline pages] Enabling notifications for pages saved later (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing missed TODO Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index 2b874332bc58508c60d21a306186a16b792aed2c..3beb0d65dacd95ae11ccf3826b11b72b9ceef0a0 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
+#include "base/supports_user_data.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
#include "components/keyed_service/core/keyed_service.h"
@@ -33,7 +34,9 @@ class SavePageRequest;
class Scheduler;
// Coordinates queueing and processing save page later requests.
-class RequestCoordinator : public KeyedService, public RequestNotifier {
+class RequestCoordinator : public KeyedService,
+ public RequestNotifier,
+ public base::SupportsUserData {
public:
// Nested observer class. To make sure that no events are missed, the client
@@ -42,6 +45,8 @@ class RequestCoordinator : public KeyedService, public RequestNotifier {
// events after the return callback from |GetAllRequests|.
class Observer {
public:
+ virtual ~Observer() = default;
+
virtual void OnAdded(const SavePageRequest& request) = 0;
virtual void OnCompleted(const SavePageRequest& request,
RequestNotifier::SavePageStatus status) = 0;

Powered by Google App Engine
This is Rietveld 408576698