components/offline_pages/background/request_coordinator.cc - Issue 2260963003: [Offline pages] Enabling notifications for pages saved later

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2260963003: [Offline pages] Enabling notifications for pages saved later (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/components_tests.gyp ('K') | « components/offline_pages/background/request_coordinator.h ('k') | components/offline_pages/background/request_notifier.h » ('j') | components/offline_pages/background/request_notifier.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.cc

diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc

index 88ebb6092d655506a1fd9a701bb813f1639ce229..1c44673b2ceb147b28a4edf08111d675754d3562 100644

--- a/components/offline_pages/background/request_coordinator.cc

+++ b/components/offline_pages/background/request_coordinator.cc

@@ -94,7 +94,6 @@ bool RequestCoordinator::SavePageLater(

queue_->AddRequest(request,

base::Bind(&RequestCoordinator::AddRequestResultCallback,

weak_ptr_factory_.GetWeakPtr()));

- NotifyAdded(request);

return true;

}

void RequestCoordinator::GetAllRequests(const GetRequestsCallback& callback) {

@@ -139,6 +138,7 @@ void RequestCoordinator::ResumeRequests(

void RequestCoordinator::AddRequestResultCallback(

RequestQueue::AddRequestResult result,

const SavePageRequest& request) {

+ NotifyAdded(request);

// Inform the scheduler that we have an outstanding task..

scheduler_->Schedule(GetTriggerConditionsForUserRequest());

}