Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: components/sync/protocol/password_specifics.proto

Issue 2260953002: Supplimentary identifier for passwords specific (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cl format Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/protocol/password_specifics.proto
diff --git a/components/sync/protocol/password_specifics.proto b/components/sync/protocol/password_specifics.proto
index ad8c9f7146c91c8a1fb37a5b6bc928951b0821b1..4358cee22dc465f824b06f15787f805765f7d5c0 100644
--- a/components/sync/protocol/password_specifics.proto
+++ b/components/sync/protocol/password_specifics.proto
@@ -110,6 +110,11 @@ message PasswordSpecificsData {
optional string federation_url = 17;
}
+// Contains the password specifics metadata which simplifies its lookup.
+message PasswordSpecificsMetadata {
+ optional string url = 1;
+};
+
// Properties of password sync objects.
message PasswordSpecifics {
// The actual password data. Contains an encrypted PasswordSpecificsData
@@ -118,4 +123,8 @@ message PasswordSpecifics {
// An unsynced field for use internally on the client. This field should
// never be set in any network-based communications.
optional PasswordSpecificsData client_only_encrypted_data = 2;
+ // Password related metadata, which is sent to the server side. The field
+ // should never be set for full encryption and data is the explicitly cleared
Nicolas Zea 2016/08/20 00:23:43 nit: the last sentence is a bit tough to parse. Ho
+ // out and no longer sent to the server.
+ optional PasswordSpecificsMetadata unencrypted_metadata = 3;
Nicolas Zea 2016/08/20 00:23:43 Note that this also needs to be added to proto_val
}

Powered by Google App Engine
This is Rietveld 408576698