Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: components/sync/core_impl/sync_encryption_handler_impl.h

Issue 2260953002: Supplimentary identifier for passwords specific (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/core_impl/sync_encryption_handler_impl.h
diff --git a/components/sync/core_impl/sync_encryption_handler_impl.h b/components/sync/core_impl/sync_encryption_handler_impl.h
index 08f99e3ef75c7ccb6dd097f995c76c6475565097..2bf0df191e62d9bb2f1b90354127d7ce8b06634d 100644
--- a/components/sync/core_impl/sync_encryption_handler_impl.h
+++ b/components/sync/core_impl/sync_encryption_handler_impl.h
@@ -61,7 +61,6 @@ class SyncEncryptionHandlerImpl : public SyncEncryptionHandler,
void SetDecryptionPassphrase(const std::string& passphrase) override;
void EnableEncryptEverything() override;
bool IsEncryptEverythingEnabled() const override;
- PassphraseType GetPassphraseType() const override;
// NigoriHandler implementation.
// Note: all methods are invoked while the caller holds a transaction.
@@ -78,6 +77,9 @@ class SyncEncryptionHandlerImpl : public SyncEncryptionHandler,
ModelTypeSet GetEncryptedTypes(
syncable::BaseTransaction* const trans) const override;
+ PassphraseType GetPassphraseType(
+ syncable::BaseTransaction* const trans) const override;
+
// Unsafe getters. Use only if sync is not up and running and there is no risk
// of other threads calling this.
Cryptographer* GetCryptographerUnsafe();
@@ -127,13 +129,18 @@ class SyncEncryptionHandlerImpl : public SyncEncryptionHandler,
// accessed via UnlockVault(..) and UnlockVaultMutable(..), which enforce
// that a transaction is held.
struct Vault {
- Vault(Encryptor* encryptor, ModelTypeSet encrypted_types);
+ Vault(Encryptor* encryptor,
+ ModelTypeSet encrypted_types,
+ PassphraseType passphrase_type);
~Vault();
// Sync's cryptographer. Used for encrypting and decrypting sync data.
Cryptographer cryptographer;
// The set of types that require encryption.
ModelTypeSet encrypted_types;
+ // The current state of the passphrase required to decrypt the encryption
+ // keys stored in the nigori node.
+ PassphraseType passphrase_type;
private:
DISALLOW_COPY_AND_ASSIGN(Vault);
@@ -226,7 +233,8 @@ class SyncEncryptionHandlerImpl : public SyncEncryptionHandler,
// Note: if the nigori node is migrated but has an invalid state, will return
// true (e.g. node has KEYSTORE_PASSPHRASE, local is CUSTOM_PASSPHRASE).
bool ShouldTriggerMigration(const sync_pb::NigoriSpecifics& nigori,
- const Cryptographer& cryptographer) const;
+ const Cryptographer& cryptographer,
+ PassphraseType* passphrase_type) const;
// Performs the actual migration of the |nigori_node| to support keystore
// encryption iff ShouldTriggerMigration(..) returns true.
@@ -263,7 +271,7 @@ class SyncEncryptionHandlerImpl : public SyncEncryptionHandler,
// If an explicit passphrase is in use, returns the time at which it was set
// (if known). Else return base::Time().
- base::Time GetExplicitPassphraseTime() const;
+ base::Time GetExplicitPassphraseTime(PassphraseType passphrase_type) const;
// Notify observers when a custom passphrase is set by this device.
void NotifyObserversOfLocalCustomPassphrase(WriteTransaction* trans);
@@ -284,9 +292,6 @@ class SyncEncryptionHandlerImpl : public SyncEncryptionHandler,
// thread.
// Whether all current and future types should be encrypted.
bool encrypt_everything_;
- // The current state of the passphrase required to decrypt the encryption
- // keys stored in the nigori node.
- PassphraseType passphrase_type_;
// The current keystore key provided by the server.
std::string keystore_key_;
« no previous file with comments | « components/sync/core/sync_encryption_handler.h ('k') | components/sync/core_impl/sync_encryption_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698