Supplimentary identifier for passwords specific

components/sync/core/write_node.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/core/write_node.h"
 
 #include <stdint.h>
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 128 matching lines @@
   // This will only update password_specifics if the underlying unencrypted blob
   // was different from |data| or was not encrypted with the proper passphrase.
   if (!cryptographer->Encrypt(data, password_specifics->mutable_encrypted())) {
     LOG(ERROR) << "Failed to encrypt password, possibly due to sync node "
                << "corruption";
     return;
   }
   SetEntitySpecifics(entity_specifics);
 }
 
+void WriteNode::SetPasswordSpecificsMetadata(
+    const sync_pb::PasswordSpecificsMetadata& specifics) {}

[Nicolas Zea, 2016/08/20 00:23:43]

I wonder if we really need this. Couldn't you set the metadata field as part of
SetPasswordSpecifics (you may need to do it within nigori_util.cc's
UpdateEntryWithEncryption in fact, which is eventually called from
SetPasswordSpecifics).  You should have access to the encryption state, and can
just clear/set the field as necessary there.

+
 void WriteNode::SetEntitySpecifics(const sync_pb::EntitySpecifics& new_value) {
   ModelType new_specifics_type = GetModelTypeFromSpecifics(new_value);
   CHECK(!new_value.password().has_client_only_encrypted_data());
   DCHECK_NE(new_specifics_type, UNSPECIFIED);
   DVLOG(1) << "Writing entity specifics of type "
            << ModelTypeToString(new_specifics_type);
   DCHECK_EQ(new_specifics_type, GetModelType());
 
   // Preserve unknown fields.
   const sync_pb::EntitySpecifics& old_specifics = entry_->GetSpecifics();
@@ skipping 310 matching lines @@
   syncable::Id predecessor_id =
       predecessor ? predecessor->GetSyncId() : syncable::Id();
   return entry_->PutPredecessor(predecessor_id);
 }
 
 void WriteNode::MarkForSyncing() {
   syncable::MarkForSyncing(entry_);
 }
 
 }  // namespace syncer