Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2260933002: Consistently use namespaced base::Version in base/ code. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently use namespaced base::Version in base/ code. BUG=639416 Committed: https://crrev.com/58f42cbc6e1bad2ca642f08d7d4cf5a029ff6808 Cr-Commit-Position: refs/heads/master@{#414771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M base/version_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pwnall
Can you please take a look?
4 years, 4 months ago (2016-08-19 20:40:22 UTC) #2
Mark Mentovai
LGTM
4 years, 3 months ago (2016-08-26 17:13:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260933002/1
4 years, 3 months ago (2016-08-26 18:11:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 19:05:02 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:16:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58f42cbc6e1bad2ca642f08d7d4cf5a029ff6808
Cr-Commit-Position: refs/heads/master@{#414771}

Powered by Google App Engine
This is Rietveld 408576698