Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 226093007: Convert Chrome usages of WebFrame to WebLocalFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index d6dbfa17f751e4ed80b3cb3061039e1b3dc57ff7..c8cbf474af41679adddf3fe28f27b28a327afe7b 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -54,6 +54,7 @@ using blink::WebFormElement;
using blink::WebFrame;
using blink::WebInputElement;
using blink::WebKeyboardEvent;
+using blink::WebLocalFrame;
using blink::WebNode;
using blink::WebOptionElement;
using blink::WebString;
@@ -166,7 +167,7 @@ bool AutofillAgent::OnMessageReceived(const IPC::Message& message) {
return handled;
}
-void AutofillAgent::DidFinishDocumentLoad(WebFrame* frame) {
+void AutofillAgent::DidFinishDocumentLoad(WebLocalFrame* frame) {
// Record timestamp on document load. This is used to record overhead of
// Autofill feature.
forms_seen_timestamp_ = base::TimeTicks::Now();
@@ -211,7 +212,7 @@ void AutofillAgent::FrameWillClose(WebFrame* frame) {
}
}
-void AutofillAgent::WillSubmitForm(WebFrame* frame,
+void AutofillAgent::WillSubmitForm(WebLocalFrame* frame,
const WebFormElement& form) {
FormData form_data;
if (WebFormElementToFormData(form,
@@ -255,11 +256,9 @@ void AutofillAgent::OrientationChangeEvent(int orientation) {
HidePopup();
}
-void AutofillAgent::DidChangeScrollOffset(WebFrame*) {
- HidePopup();
-}
+void AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { HidePopup(); }
jam 2014/04/05 00:12:39 ditto
jam 2014/04/07 16:33:59 this goes against the style guide, which says that
dcheng 2014/04/07 16:46:58 Maybe I'm missing something, but I think the open
jam 2014/04/07 21:16:33 the doc says the open curly brace is at the _end_,
dcheng 2014/04/07 22:19:20 Ah. I missed that bit. Filing a clang-format bug a
-void AutofillAgent::didRequestAutocomplete(WebFrame* frame,
+void AutofillAgent::didRequestAutocomplete(WebLocalFrame* frame,
const WebFormElement& form) {
// Disallow the dialog over non-https or broken https, except when the
// ignore SSL flag is passed. See http://crbug.com/272512.

Powered by Google App Engine
This is Rietveld 408576698