Convert Chrome usages of WebFrame to WebLocalFrame.

Convert Chrome usages of WebFrame to WebLocalFrame.

This is a mechanical change to followup on Blink and content changes to
change parameter types to WebLocalFrame where appropriate.

BUG=346764
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262320

[dcheng, 2014-04-04 23:53:40]

This is a followup patch that builds on
https://codereview.chromium.org/222973003/. It is mostly mechanical--the
locations I needed to update were determined by fixing all the compile errors
that resulted from changing WebLocalFrame from a typedef to a subclass.

This is what's required to build the 'chrome' target; all that's left after this
is updating a million tests...

[dcheng, 2014-04-04 23:54:23]

(jam for reviewing chrome changes, isherman for components/autofill, and jochen
for components/plugins)

[jam, 2014-04-05 00:12:38]

lgtm with nits

https://codereview.chromium.org/226093007/diff/1/chrome/renderer/printing/pri...
File chrome/renderer/printing/print_web_view_helper.cc (right):

https://codereview.chromium.org/226093007/diff/1/chrome/renderer/printing/pri...
chrome/renderer/printing/print_web_view_helper.cc:920: // need to make sure this
is dispatched correctly.
nit: i'm a bit hesitant to start adding comments to code saying it'll have to
change for OOPIF. that seems obvious for any code that uses webview..

https://codereview.chromium.org/226093007/diff/1/chrome/renderer/safe_browsin...
File chrome/renderer/safe_browsing/phishing_classifier_delegate.cc (right):

https://codereview.chromium.org/226093007/diff/1/chrome/renderer/safe_browsin...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:146:
blink::WebLocalFrame* frame,
why change the spacing? it seems like this will fit on one line, so best to
leave as is

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.cc:259: void
AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { HidePopup(); }
ditto

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.h (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.h:87: OVERRIDE;
again, please leave formatting the same which renaming classes etc.

[dcheng, 2014-04-05 00:42:22]

Re: style reformatting is a result of clang-format. The renaming pushed a few
lines over the length limit and usually I just clang-format the whole patch to
keep things simple.

I can individually revert individual instances, but it's really much easier to
be able to format the whole CL to keep it well formatted. =/

https://codereview.chromium.org/226093007/diff/1/chrome/renderer/printing/pri...
File chrome/renderer/printing/print_web_view_helper.cc (right):

https://codereview.chromium.org/226093007/diff/1/chrome/renderer/printing/pri...
chrome/renderer/printing/print_web_view_helper.cc:920: // need to make sure this
is dispatched correctly.
On 2014/04/05 00:12:39, jam wrote:
> nit: i'm a bit hesitant to start adding comments to code saying it'll have to
> change for OOPIF. that seems obvious for any code that uses webview..

I don't usually add these comments, but there's an explicit comment where we
call this function and it says "this might not actually be the right frame" so I
wanted to highlight that fact. I don't feel strongly about keeping this comment
though so I'll revert it in the next patchset.

[jochen (gone - plz use gerrit), 2014-04-07 13:00:01]

i'm all for clang-formating the world

components/plugins lgtm

[jam, 2014-04-07 16:33:58]

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.cc:259: void
AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { HidePopup(); }
On 2014/04/05 00:12:39, jam wrote:
> ditto

this goes against the style guide, which says that
"The open curly brace is always at the end of the same line as the last
parameter."

[dcheng, 2014-04-07 16:46:57]

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.cc:259: void
AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { HidePopup(); }
On 2014/04/07 16:33:59, jam wrote:
> On 2014/04/05 00:12:39, jam wrote:
> > ditto
> 
> this goes against the style guide, which says that
> "The open curly brace is always at the end of the same line as the last
> parameter."

Maybe I'm missing something, but I think the open curly brace is on the same
line as the last parameter?

[Ilya Sherman, 2014-04-07 20:28:08]

autofill lgtm

[jam, 2014-04-07 21:16:33]

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.cc:259: void
AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { HidePopup(); }
On 2014/04/07 16:46:58, dcheng wrote:
> On 2014/04/07 16:33:59, jam wrote:
> > On 2014/04/05 00:12:39, jam wrote:
> > > ditto
> > 
> > this goes against the style guide, which says that
> > "The open curly brace is always at the end of the same line as the last
> > parameter."
> 
> Maybe I'm missing something, but I think the open curly brace is on the same
> line as the last parameter?

the doc says the open curly brace is at the _end_, which this code isn't (i.e.
there is stuff after it)

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.h (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.h:87: OVERRIDE;
On 2014/04/05 00:12:39, jam wrote:
> again, please leave formatting the same which renaming classes etc.

this seems worse readability-wise, and i'm pretty sure we used to tell people
not to start a line with override (or const). so this is a step back imo

[dcheng, 2014-04-07 22:19:20]

So I've gone ahead and reverted any clang-format changes that weren't required
for line-too-long fixes, and made sure the resulting changes weren't
objectionable.

... hilariously the presubmit now warns me that my CL isn't clang formatted
because chrome/renderer/extensions has a clang-format check in its PRESUBMIT.py.
I've ignored it for now =/

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.cc:259: void
AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { HidePopup(); }
On 2014/04/07 21:16:33, jam wrote:
> On 2014/04/07 16:46:58, dcheng wrote:
> > On 2014/04/07 16:33:59, jam wrote:
> > > On 2014/04/05 00:12:39, jam wrote:
> > > > ditto
> > > 
> > > this goes against the style guide, which says that
> > > "The open curly brace is always at the end of the same line as the last
> > > parameter."
> > 
> > Maybe I'm missing something, but I think the open curly brace is on the same
> > line as the last parameter?
> 
> the doc says the open curly brace is at the _end_, which this code isn't (i.e.
> there is stuff after it)

Ah. I missed that bit. Filing a clang-format bug about this one.

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
File components/autofill/content/renderer/autofill_agent.h (right):

https://codereview.chromium.org/226093007/diff/1/components/autofill/content/...
components/autofill/content/renderer/autofill_agent.h:87: OVERRIDE;
On 2014/04/07 21:16:33, jam wrote:
> On 2014/04/05 00:12:39, jam wrote:
> > again, please leave formatting the same which renaming classes etc.
> 
> this seems worse readability-wise, and i'm pretty sure we used to tell people
> not to start a line with override (or const). so this is a step back imo

Done.

[dcheng, 2014-04-08 00:02:10]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-04-08 00:03:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/226093007/60001

[commit-bot: I haz the power, 2014-04-08 05:06:49]

Change committed as 262320