Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2260923002: Revert of Disable broken WebKit tests also on Mac10.11 and Linux (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable broken WebKit tests also on Mac10.11 and Linux (patchset #1 id:1 of https://codereview.chromium.org/2254973007/ ) Reason for revert: Bug should be fixed. Reenabling tests. Original issue's description: > Disable broken WebKit tests also on Mac10.11 and Linux > > Follow-up to https://codereview.chromium.org/2263563002/ > > BUG=639179 > TBR=msarett@chromium.org > NOTRY=true > > Committed: https://crrev.com/82d37bfa3a4947b5005b722ee96e83260f1b3c22 > Cr-Commit-Position: refs/heads/master@{#413117} TBR=msarett@chromium.org,treib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639179 Committed: https://crrev.com/9eda0c10aa70db52f93af87bd346934dea7f4388 Cr-Commit-Position: refs/heads/master@{#413225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
msarett
Created Revert of Disable broken WebKit tests also on Mac10.11 and Linux
4 years, 4 months ago (2016-08-19 20:01:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260923002/1
4 years, 4 months ago (2016-08-19 20:02:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-19 20:03:00 UTC) #5
msarett
4 years, 4 months ago (2016-08-19 20:05:06 UTC) #7
robertphillips1
lgtm
4 years, 4 months ago (2016-08-19 20:11:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260923002/1
4 years, 4 months ago (2016-08-19 20:12:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 20:13:36 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 20:15:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eda0c10aa70db52f93af87bd346934dea7f4388
Cr-Commit-Position: refs/heads/master@{#413225}

Powered by Google App Engine
This is Rietveld 408576698