Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 2260913003: Disable automatic frame rate conversion for MediaCodec on nVidia shields (Closed)

Created:
4 years, 4 months ago by watk
Modified:
4 years, 4 months ago
Reviewers:
DaleCurtis
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, n-kozlov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable automatic frame rate conversion for MediaCodec on nVidia shields MediaCodec on nVidia shield tablets has logic to change the frame timestamps to convert the video frame rate to better map to the display refresh rate. This breaks AVDA because it assumes the timestamps of the frames submitted to MediaCodec are unaltered. The workaround, taken from ExoPlayer, is to set "auto-frc": 0 in the MediaFormat. BUG=637606

Patch Set 1 #

Patch Set 2 : All android version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
watk
Untested until we get the shield.
4 years, 4 months ago (2016-08-20 01:17:22 UTC) #2
DaleCurtis
On 2016/08/20 at 01:17:22, watk wrote: > Untested until we get the shield. I think ...
4 years, 4 months ago (2016-08-21 22:49:53 UTC) #3
watk
On 2016/08/21 22:49:53, DaleCurtis wrote: > On 2016/08/20 at 01:17:22, watk wrote: > > Untested ...
4 years, 4 months ago (2016-08-22 17:19:40 UTC) #4
DaleCurtis
lgtm assuming nvidia engineers can test this on a shield they have.
4 years, 4 months ago (2016-08-22 17:29:52 UTC) #5
watk
4 years, 4 months ago (2016-08-23 20:22:09 UTC) #7
Message was sent while issue was closed.
Closing. This wasn't the actual issue. "Framerate filtering" is the thing
adjusting timestamps.

Powered by Google App Engine
This is Rietveld 408576698