Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: build/config/clang/BUILD.gn

Issue 2260913002: build: Remove enabled-by-default check-implicit-copy-ctors flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("clang.gni") 5 import("clang.gni")
6 import("//build/config/chromecast_build.gni") 6 import("//build/config/chromecast_build.gni")
7 7
8 config("find_bad_constructs") { 8 config("find_bad_constructs") {
9 if (clang_use_chrome_plugins) { 9 if (clang_use_chrome_plugins) {
10 cflags = [] 10 cflags = []
(...skipping 25 matching lines...) Expand all
36 "-Xclang", 36 "-Xclang",
37 "find-bad-constructs", 37 "find-bad-constructs",
38 "-Xclang", 38 "-Xclang",
39 "-plugin-arg-find-bad-constructs", 39 "-plugin-arg-find-bad-constructs",
40 "-Xclang", 40 "-Xclang",
41 "check-templates", 41 "check-templates",
42 "-Xclang", 42 "-Xclang",
43 "-plugin-arg-find-bad-constructs", 43 "-plugin-arg-find-bad-constructs",
44 "-Xclang", 44 "-Xclang",
45 "follow-macro-expansion", 45 "follow-macro-expansion",
46 "-Xclang",
47 "-plugin-arg-find-bad-constructs",
48 "-Xclang",
49 "check-implicit-copy-ctors",
50 ] 46 ]
51 47
52 if ((is_linux || is_android) && !is_chromecast) { 48 if ((is_linux || is_android) && !is_chromecast) {
53 cflags += [ 49 cflags += [
54 "-Xclang", 50 "-Xclang",
55 "-plugin-arg-find-bad-constructs", 51 "-plugin-arg-find-bad-constructs",
56 "-Xclang", 52 "-Xclang",
57 "check-ipc", 53 "check-ipc",
58 ] 54 ]
59 } 55 }
60 } 56 }
61 } 57 }
62 58
63 # Enables some extra Clang-specific warnings. Some third-party code won't 59 # Enables some extra Clang-specific warnings. Some third-party code won't
64 # compile with these so may want to remove this config. 60 # compile with these so may want to remove this config.
65 config("extra_warnings") { 61 config("extra_warnings") {
66 cflags = [ 62 cflags = [
67 "-Wheader-hygiene", 63 "-Wheader-hygiene",
68 64
69 # Warns when a const char[] is converted to bool. 65 # Warns when a const char[] is converted to bool.
70 "-Wstring-conversion", 66 "-Wstring-conversion",
71 ] 67 ]
72 } 68 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698