Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: build/common.gypi

Issue 2260913002: build: Remove enabled-by-default check-implicit-copy-ctors flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2202 matching lines...) Expand 10 before | Expand all | Expand 10 after
2213 # no need to load it dynamically. 2213 # no need to load it dynamically.
2214 'clang_dynlib_flags%': '', 2214 'clang_dynlib_flags%': '',
2215 }], 2215 }],
2216 ['(OS=="android" or OS=="linux") and chromecast==0', { 2216 ['(OS=="android" or OS=="linux") and chromecast==0', {
2217 'clang_plugin_check_ipc_arg': '-Xclang -plugin-arg-find-bad-constr ucts -Xclang check-ipc', 2217 'clang_plugin_check_ipc_arg': '-Xclang -plugin-arg-find-bad-constr ucts -Xclang check-ipc',
2218 }, { 2218 }, {
2219 'clang_plugin_check_ipc_arg': '', 2219 'clang_plugin_check_ipc_arg': '',
2220 }], 2220 }],
2221 ], 2221 ],
2222 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ' 2222 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates '
2223 '-Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansio n ' 2223 '-Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansio n ',
2224 '-Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-c tors ',
2225 }, 2224 },
2226 # If you change these, also change build/config/clang/BUILD.gn. 2225 # If you change these, also change build/config/clang/BUILD.gn.
2227 'clang_chrome_plugins_flags%': 2226 'clang_chrome_plugins_flags%':
2228 '<(clang_dynlib_flags)' 2227 '<(clang_dynlib_flags)'
2229 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args) <(clang_plugin_check_ipc_arg)', 2228 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args) <(clang_plugin_check_ipc_arg)',
2230 }], 2229 }],
2231 ['asan==1 or msan==1 or lsan==1 or tsan==1', { 2230 ['asan==1 or msan==1 or lsan==1 or tsan==1', {
2232 'clang%': 1, 2231 'clang%': 1,
2233 'use_allocator%': 'none', 2232 'use_allocator%': 'none',
2234 'use_sanitizer_options%': 1, 2233 'use_sanitizer_options%': 1,
(...skipping 4094 matching lines...) Expand 10 before | Expand all | Expand 10 after
6329 # settings in target dicts. SYMROOT is a special case, because many other 6328 # settings in target dicts. SYMROOT is a special case, because many other
6330 # Xcode variables depend on it, including variables such as 6329 # Xcode variables depend on it, including variables such as
6331 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6330 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6332 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6331 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6333 # files to appear (when present) in the UI as actual files and not red 6332 # files to appear (when present) in the UI as actual files and not red
6334 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6333 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6335 # and therefore SYMROOT, needs to be set at the project level. 6334 # and therefore SYMROOT, needs to be set at the project level.
6336 'SYMROOT': '<(DEPTH)/xcodebuild', 6335 'SYMROOT': '<(DEPTH)/xcodebuild',
6337 }, 6336 },
6338 } 6337 }
OLDNEW
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698