Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2260913002: build: Remove enabled-by-default check-implicit-copy-ctors flag. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Remove enabled-by-default check-implicit-copy-ctors flag. This flag is now enabled by default, so we don't need to specify it. Remove it from the build files. R=thakis@chromium.org Committed: https://crrev.com/113b383d7cc3abfd48e4d8a6c318dc6c50d57d3f Cr-Commit-Position: refs/heads/master@{#413459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/common.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-08-19 19:56:09 UTC) #1
Nico
rs-lgtm
4 years, 4 months ago (2016-08-22 14:10:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260913002/1
4 years, 4 months ago (2016-08-22 14:12:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 17:07:37 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:09:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/113b383d7cc3abfd48e4d8a6c318dc6c50d57d3f
Cr-Commit-Position: refs/heads/master@{#413459}

Powered by Google App Engine
This is Rietveld 408576698