Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2260873003: Revert of Fix MediaRouterContextualMenuUnitTest (Closed)

Created:
4 years, 4 months ago by takumif
Modified:
4 years, 4 months ago
Reviewers:
mark a. foltz, msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix MediaRouterContextualMenuUnitTest (patchset #1 id:1 of https://codereview.chromium.org/2253613003/ ) Reason for revert: Reverting this CL as well as the other CL[1] this was meant to fix. They are causing crashes and need a redesign. [1] https://codereview.chromium.org/2155293002 Original issue's description: > Fix MediaRouterContextualMenuUnitTest > > This CL resolves the compliation error in the unit test introduced > by https://codereview.chromium.org/2155293002. > > TBR=msw@chromium.org > BUG=638300 > > Committed: https://crrev.com/0d3d4235ebcd37fa56b05517c9d97c018e8c0f5f > Cr-Commit-Position: refs/heads/master@{#412332} TBR=msw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638300 Committed: https://crrev.com/b61db4502430b2ed441ce4f1e75c1db593dd3691 Cr-Commit-Position: refs/heads/master@{#413339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
takumif
Created Revert of Fix MediaRouterContextualMenuUnitTest
4 years, 4 months ago (2016-08-19 22:11:21 UTC) #1
mark a. foltz
lgtm
4 years, 4 months ago (2016-08-19 22:31:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260873003/1
4 years, 4 months ago (2016-08-20 15:30:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 15:35:01 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 15:38:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b61db4502430b2ed441ce4f1e75c1db593dd3691
Cr-Commit-Position: refs/heads/master@{#413339}

Powered by Google App Engine
This is Rietveld 408576698