Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226083005: Linux sandbox: componentize almost everything. (Closed)

Created:
6 years, 8 months ago by jln (very slow on Chromium)
Modified:
6 years, 8 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux sandbox: componentize almost everything. Componentize seccomp_bpf_helpers, sandbox_services and suid_sandbox_client. libc_urandom_override is special since it uses weak symbols hackery. BUG=360124 R=mdempsky@chromium.org TBR=jln Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261945

Patch Set 1 #

Patch Set 2 : Update dependencies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -24 lines) Patch
M sandbox/linux/sandbox_linux.gypi View 1 5 chunks +14 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.h View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h View 2 chunks +9 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h View 2 chunks +10 lines, -8 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.h View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/linux/services/broker_process.h View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/linux/services/credentials.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/services/init_process_reaper.h View 2 chunks +3 lines, -1 line 0 comments Download
M sandbox/linux/services/scoped_process.h View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/linux/services/thread_helpers.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/services/yama.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_client.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jln (very slow on Chromium)
Matthew: PTAL!
6 years, 8 months ago (2014-04-04 22:52:15 UTC) #1
mdempsky
lgtm
6 years, 8 months ago (2014-04-04 23:02:41 UTC) #2
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 8 months ago (2014-04-04 23:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/226083005/1
6 years, 8 months ago (2014-04-04 23:05:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 23:55:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=130103
6 years, 8 months ago (2014-04-04 23:56:00 UTC) #6
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 8 months ago (2014-04-04 23:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/226083005/20001
6 years, 8 months ago (2014-04-04 23:57:06 UTC) #8
jln (very slow on Chromium)
6 years, 8 months ago (2014-04-05 00:47:22 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r261945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698