Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 22608004: Improve 'Selection' exception messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: ugh. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionMessages.h ('k') | Source/core/page/DOMSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionMessages.cpp
diff --git a/Source/bindings/v8/custom/V8WorkerCryptoCustom.cpp b/Source/bindings/v8/ExceptionMessages.cpp
similarity index 87%
copy from Source/bindings/v8/custom/V8WorkerCryptoCustom.cpp
copy to Source/bindings/v8/ExceptionMessages.cpp
index 539b9ed11590c17ec5ce2bbc307520a49e6ac24e..15c7f28eb87c63553e4a9e7ba5c2d2414d5a9c43 100644
--- a/Source/bindings/v8/custom/V8WorkerCryptoCustom.cpp
+++ b/Source/bindings/v8/ExceptionMessages.cpp
@@ -29,15 +29,13 @@
*/
#include "config.h"
-#include "V8WorkerCrypto.h"
-
-#include "V8Crypto.h"
+#include "bindings/v8/ExceptionMessages.h"
namespace WebCore {
-void V8WorkerCrypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+String ExceptionMessages::failedToExecute(const String& method, const String& type, const String& detail)
{
- V8Crypto::getRandomValuesMethodCustom(args);
+ return "Failed to execute '" + method + "' on '" + type + "': " + detail;
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/ExceptionMessages.h ('k') | Source/core/page/DOMSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698