Improve 'Selection' exception messages.

LayoutTests/fast/dom/Selection/script-tests/collapseToX-empty-selection.js

Index: LayoutTests/fast/dom/Selection/script-tests/collapseToX-empty-selection.js
diff --git a/LayoutTests/fast/dom/Selection/script-tests/collapseToX-empty-selection.js b/LayoutTests/fast/dom/Selection/script-tests/collapseToX-empty-selection.js
index 3910c735c54b6d6da1a1673fb5cec48283f4d422..0b1840386610270d82413dae9e8eddf683f0a6ed 100644
--- a/LayoutTests/fast/dom/Selection/script-tests/collapseToX-empty-selection.js
+++ b/LayoutTests/fast/dom/Selection/script-tests/collapseToX-empty-selection.js
@@ -4,8 +4,8 @@ var sel = window.getSelection();
 var textNode = document.createTextNode("abcdef");
 document.body.appendChild(textNode);
 
-shouldThrow("sel.collapseToStart()", "'InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable.'");
-shouldThrow("sel.collapseToEnd()", "'InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable.'");
+shouldThrow("sel.collapseToStart()");

[arv (Not doing code reviews), 2013/08/13 13:57:31]

Why don't you want to test the message any more?

[Mike West, 2013/08/13 14:00:17]

Laziness?

I realized that `shouldThrow` will output the message to the expectations file
if I leave the second parameter off entirely. That's a lot less work than
updating all the HTML files every time we iterated on some text. :)

[arv (Not doing code reviews), 2013/08/13 14:07:49]

I thought as much.

The problem is that we will end up with PASS even if the wrong exception is
thrown. It will require updating the expectation but as long as it says PASS I
doubt people will realize that they might have broken something.

(I really hate how we write our tests and this is one of the reasons.)

[Mike West, 2013/08/13 14:09:20]

That's a fair point. Hrm.

Ok. I'll attempt to overcome my laziness. :/

+shouldThrow("sel.collapseToEnd()");
 
 sel.selectAllChildren(textNode);