components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace function pointer, use multiple if-continue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index c77fd77ae28bb5a5d454e4c3c472d1ba93dfe85f..a15acc5138b85843c742e7ac3a58c364c8f94213 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -89,11 +89,11 @@ void PhysicalWebPageSuggestionsProvider::ClearCachedSuggestionsForDebugging(

// Ignored

}

-std::vector<ContentSuggestion>

-PhysicalWebPageSuggestionsProvider::GetDismissedSuggestionsForDebugging(

- Category category) {

+void PhysicalWebPageSuggestionsProvider::GetDismissedSuggestionsForDebugging(

+ Category category,

+ const DismissedSuggestionsCallback& callback) {

// Not implemented.

- return std::vector<ContentSuggestion>();

+ callback.Run(std::vector<ContentSuggestion>());

}

void PhysicalWebPageSuggestionsProvider::ClearDismissedSuggestionsForDebugging(

« no previous file with comments | « components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h ('k') | no next file » | no next file with comments »